[webkit-reviews] review granted: [Bug 194413] REGRESSION: [ Mac Debug WK2 ] Layout Test storage/indexeddb/key-type-infinity-private.html is a flaky crash : [Attachment 361690] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 09:12:40 PST 2019


Brady Eidson <beidson at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 194413: REGRESSION: [ Mac Debug WK2 ] Layout Test
storage/indexeddb/key-type-infinity-private.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=194413

Attachment 361690: Patch

https://bugs.webkit.org/attachment.cgi?id=361690&action=review




--- Comment #12 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 361690
  --> https://bugs.webkit.org/attachment.cgi?id=361690
Patch

Yah I guess callbacks are just Function<> typedefs and don't all exist in one
big set.

We should change that which could greatly simplify all of this code.

But that's a refactor task that is greater than this patch.


More information about the webkit-reviews mailing list