[webkit-reviews] review granted: [Bug 194446] Fix DFG's doesGC() for CheckTierUp*, GetByVal, PutByVal*, and StringCharAt nodes. : [Attachment 361529] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 194446: Fix DFG's doesGC() for CheckTierUp*, GetByVal, PutByVal*, and
StringCharAt nodes.
https://bugs.webkit.org/show_bug.cgi?id=194446

Attachment 361529: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=361529&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 361529
  --> https://bugs.webkit.org/attachment.cgi?id=361529
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=361529&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2197
>      JITCompiler::Jump bigCharacter =
> -	   m_jit.branch32(MacroAssembler::AboveOrEqual, scratchReg,
TrustedImm32(0x100));
> +	   m_jit.branch32(MacroAssembler::Above, scratchReg,
TrustedImm32(maxSingleCharacterString));

This really doesn't belong in this patch.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:6615
> +	       m_out.above(char16BitValue,
m_out.constInt32(maxSingleCharacterString)),

ditto