[webkit-reviews] review granted: [Bug 194445] Web Inspector: Add Debug setting to show Internal Object Classes in Heap Snapshot : [Attachment 361523] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194445: Web Inspector: Add Debug setting to show Internal Object Classes in
Heap Snapshot
https://bugs.webkit.org/show_bug.cgi?id=194445

Attachment 361523: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=361523&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 361523
  --> https://bugs.webkit.org/attachment.cgi?id=361523
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=361523&action=review

rs=me

Can you attach a screenshot, just so we can see what types of things would
appear?  Considering that we've never shown internal objects (unless they were
also used non-internally), it may be useful to know what they look like for
future reference.

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:332
>  

Aside: should there also be a separator between "Debugging:" and "Uncaught
Exception Reporter:"?