[webkit-reviews] review denied: [Bug 205217] Nullptr crash if SVG element if element parent becomes document node : [Attachment 385646] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Sunny He <sunny_he at apple.com>'s
request for review:
Bug 205217: Nullptr crash if SVG element if element parent becomes document
node
https://bugs.webkit.org/show_bug.cgi?id=205217

Attachment 385646: Patch

https://bugs.webkit.org/attachment.cgi?id=385646&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 385646
  --> https://bugs.webkit.org/attachment.cgi?id=385646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385646&action=review

> Source/WebCore/rendering/svg/RenderSVGText.cpp:377
> +    } else if (m_needsTextMetricsUpdate) {
> +	   RenderSVGRoot* rootObj =
SVGRenderSupport::findTreeRootObject(*this);
> +	   if (rootObj && rootObj->isLayoutSizeChanged()) {

This implements &&, but in the old code it was ||.