[webkit-reviews] review granted: [Bug 205230] Fix bad exception assertion in ExceptionHelpers.cpp's createError(). : [Attachment 385664] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 205230: Fix bad exception assertion in ExceptionHelpers.cpp's
createError().
https://bugs.webkit.org/show_bug.cgi?id=205230

Attachment 385664: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=385664&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 385664
  --> https://bugs.webkit.org/attachment.cgi?id=385664
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=385664&action=review

r=me with nit.

> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:269
> -    EXCEPTION_ASSERT(scope.exception() || !!valueDescription);
> -    if (!valueDescription) {
> +    if (scope.exception() || !valueDescription) {

Can you add a comment why we are not returning when we have
`scope.exception()`?