[webkit-reviews] review denied: [Bug 204932] Create WebKit API calls for ITP Data : [Attachment 385220] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied
katherine_cheney at apple.com's request for review:
Bug 204932: Create WebKit API calls for ITP Data
https://bugs.webkit.org/show_bug.cgi?id=204932

Attachment 385220: Patch

https://bugs.webkit.org/attachment.cgi?id=385220&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 385220
  --> https://bugs.webkit.org/attachment.cgi?id=385220
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385220&action=review

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1166
> +	   Vector<WebResourceLoadStatisticsStore::ThirdPartyData>
thirdPartyData = m_statisticsStore->aggregatedThirdPartyData();

I think this could be auto.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:532
> +	   completionHandler(WTFMove(apiThirdParties));

It's a little strange to WTFMove an ObjC pointer.  Let's not.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:535
> +    completionHandler({ });

This should be nil.

> Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

2019

> Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.mm:2
> + * Copyright (C) 2015 Apple Inc. All rights reserved.

2019.
All your copyright dates need updating.

> Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.mm:37
> +    self.firstPartyDomain = domain;
> +    self.thirdPartyStorageAccessGranted = storageAccess;

Please make these wrappers of C++ objects like all our other API objects.  See
WKWebpagePreferences for an example.