[webkit-reviews] review granted: [Bug 205095] IndexedDB: Introduce WebIDBServer class : [Attachment 385397] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 11 09:20:40 PST 2019
Alex Christensen <achristensen at apple.com> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 205095: IndexedDB: Introduce WebIDBServer class
https://bugs.webkit.org/show_bug.cgi?id=205095
Attachment 385397: Patch
https://bugs.webkit.org/attachment.cgi?id=385397&action=review
--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 385397
--> https://bugs.webkit.org/attachment.cgi?id=385397
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=385397&action=review
> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:90
> + RefPtr<WebCore::IDBServer::IDBServer> m_server;
This could be a Ref.
> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:91
> + bool m_isSuspended { false };
This could be wrapped in #if !ASSERT_DISABLED
Not too important, though.
More information about the webkit-reviews
mailing list