[webkit-reviews] review granted: [Bug 205035] Web Inspector: REGRESSION(r251038): Elements: Computed: implicit shorthands are not shown when "Prefer Shorthands" is enabled : [Attachment 385218] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 205035: Web Inspector: REGRESSION(r251038): Elements: Computed: implicit
shorthands are not shown when "Prefer Shorthands" is enabled
https://bugs.webkit.org/show_bug.cgi?id=205035

Attachment 385218: Patch

https://bugs.webkit.org/attachment.cgi?id=385218&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 385218
  --> https://bugs.webkit.org/attachment.cgi?id=385218
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385218&action=review

r=me

> Source/WebInspectorUI/ChangeLog:17
> +	   Drive-by: filter the list of properties to render before sorting
them for performance.

Does this affect the display order? Is it already being sorted?

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:170
> +		   if (!(this._showsShorthandsInsteadOfLonghands &&
property.isShorthand && hasNonImplicitLonghand(property)))

I wish it were possible to fold this into the guard below, but alas, it early
exits too early otherwise.