[webkit-reviews] review granted: [Bug 205039] Web Inspector: Elements: Styles: hovering over an invalid value while holding ⌘ doesn't change the color of the text : [Attachment 385212] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 10 12:10:53 PST 2019


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 205039: Web Inspector: Elements: Styles: hovering over an invalid value
while holding ⌘ doesn't change the color of the text
https://bugs.webkit.org/show_bug.cgi?id=205039

Attachment 385212: Patch

https://bugs.webkit.org/attachment.cgi?id=385212&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 385212
  --> https://bugs.webkit.org/attachment.cgi?id=385212
Patch

r=me
It still seems a bit wonky if you hover a property value and then press
command. In that case, not all of the other properties and values in the
section get the underlining until mouse hover leaves and re-enters the entire
section. But this part is not a regression. Can you see if you are able to
repro that behavior?


More information about the webkit-reviews mailing list