[webkit-reviews] review denied: [Bug 200163] JPEGImageDecoder: use libjpeg-turbo RGBA output path even for Adobe transform=0 JPEGs : [Attachment 374964] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Loïc Yhuel
<loic.yhuel at softathome.com>'s request for review:
Bug 200163: JPEGImageDecoder: use libjpeg-turbo RGBA output path even for Adobe
transform=0 JPEGs
https://bugs.webkit.org/show_bug.cgi?id=200163

Attachment 374964: Patch

https://bugs.webkit.org/attachment.cgi?id=374964&action=review




--- Comment #19 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 374964
  --> https://bugs.webkit.org/attachment.cgi?id=374964
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374964&action=review

> Source/WebCore/platform/ImageDecoders.cmake:71
> +	       set_property(SOURCE
platform/image-decoders/jpeg/JPEGImageDecoder.cpp APPEND PROPERTY
COMPILE_DEFINITIONS "LIBJPEG_TURBO_SUPPORTS_CONVERSIONS_FROM_RGB")

Let's remove the workaround. Make it a fatal error at CMake phase by using
message(FATAL_ERROR "") if you want.