[webkit-reviews] review granted: [Bug 200535] Origin header not included in WebSocket handshake request when using platform WebSocket API : [Attachment 377323] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 27 00:21:53 PDT 2019


youenn fablet <youennf at gmail.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 200535: Origin header not included in WebSocket handshake request when
using platform WebSocket API
https://bugs.webkit.org/show_bug.cgi?id=200535

Attachment 377323: Patch

https://bugs.webkit.org/attachment.cgi?id=377323&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 377323
  --> https://bugs.webkit.org/attachment.cgi?id=377323
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377323&action=review

> Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp:113
> +    request.setHTTPHeaderField(HTTPHeaderName::Origin,
document.securityOrigin().toString());

Can we add a test for it?


More information about the webkit-reviews mailing list