[webkit-reviews] review granted: [Bug 199719] [MSE][GStreamer] WebKitMediaSrc rework : [Attachment 376690] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 199719: [MSE][GStreamer] WebKitMediaSrc rework
https://bugs.webkit.org/show_bug.cgi?id=199719

Attachment 376690: Patch

https://bugs.webkit.org/attachment.cgi?id=376690&action=review




--- Comment #64 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 376690
  --> https://bugs.webkit.org/attachment.cgi?id=376690
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376690&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:750
> +    bool firstTimeConnectingTrack = (m_track == nullptr);

These () are not needed. and isFirstTimeConn...

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:8
> + * Copyright (C) 2009, 2010, 2011, 2012, 2013, 2016, 2017, 2019 Igalia S.L
>   * Copyright (C) 2015 Sebastian Dröge <sebastian at centricular.com>
> - * Copyright (C) 2015, 2016, 2017 Metrological Group B.V.
> + * Copyright (C) 2015, 2016, 2017, 2019 Metrological Group B.V.

I think you can also add 2018, AFAIK, we didn't stop working here.

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:213
> +	   if (!changePipelineState(GST_STATE_PLAYING)) {

Remove the { }

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:218
> +	   if (!changePipelineState(GST_STATE_PAUSED)) {

ditto

>
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:7
> + *  Copyright (C) 2015, 2016, 2019 Metrological Group B.V.
> + *  Copyright (C) 2015, 2016, 2019 Igalia, S.L

2018

>
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:4
09
> +	   // Unblock the streaming thread

.

>
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:5
26
> +	       // This sample needs new caps (typically because of a quality
change)

.