[webkit-reviews] review granted: [Bug 201139] run-webkit-tests: Cap the number of automatically booted simulators at 12 : [Attachment 377245] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 201139: run-webkit-tests: Cap the number of automatically booted simulators
at 12
https://bugs.webkit.org/show_bug.cgi?id=201139

Attachment 377245: Patch

https://bugs.webkit.org/attachment.cgi?id=377245&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 377245
  --> https://bugs.webkit.org/attachment.cgi?id=377245
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377245&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:422
> +	   max_supported_simulators_for_hardware =
min(host.executive.cpu_count() // 2, host.platform.total_bytes_memory() //
SimulatedDeviceManager.MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE, 12)

Please store 12 in a separate variable, something like
MAX_NUMBER_OF_SIMULATORS.