[webkit-reviews] review denied: [Bug 200747] Web Inspector: have more aggressive checks for dataURLs provided to `console.screenshot` : [Attachment 376422] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200747: Web Inspector: have more aggressive checks for dataURLs provided to
`console.screenshot`
https://bugs.webkit.org/show_bug.cgi?id=200747

Attachment 376422: Patch

https://bugs.webkit.org/attachment.cgi?id=376422&action=review




--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 376422
  --> https://bugs.webkit.org/attachment.cgi?id=376422
Patch

I what we ended up agreeing on was:

  • Special case "data:" to send as an image
  • If rendering the dataURL fails (onerror) in the frontend, output an error
message without a broken image icon

Frontend could avoid flashes but given this (errors) is such an unlikely case
I'm not sure it matters much.