[webkit-reviews] review granted: [Bug 198017] Web Inspector: Sources: gear icons moves to 2nd line when sidebar is narrow : [Attachment 376347] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 198017: Web Inspector: Sources: gear icons moves to 2nd line when sidebar
is narrow
https://bugs.webkit.org/show_bug.cgi?id=198017

Attachment 376347: Patch

https://bugs.webkit.org/attachment.cgi?id=376347&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 376347
  --> https://bugs.webkit.org/attachment.cgi?id=376347
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376347&action=review

r=me

> Source/WebInspectorUI/ChangeLog:54
> +
> +

Nit: too many lines

> Source/WebInspectorUI/UserInterface/Views/TextNavigationItem.js:40
>      // Public
>  
> +    get totalMargin()

Shouldn't this be in some Protected region?