[webkit-reviews] review denied: [Bug 200761] Web Inspector: Sources: enable by default : [Attachment 376363] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 16 01:04:32 PDT 2019

Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200761: Web Inspector: Sources: enable by default

Attachment 376363: Patch


--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 376363
  --> https://bugs.webkit.org/attachment.cgi?id=376363

I suggest holding off on this a bit. Lets revisit this in a month.

I want to live on the Sources tab a bit more myself to ensure it feels good and
to catch any possible issues. I suggest that others live on it and provide
feedback here if they think something aught be addressed before it is enabled
by default. I've only been living on it for about a week and have some


I want to replace the default sources scope bar control to toggle between
`Group by Path` / `Group by Type`. The current scope bar is a Resource Type
filter, which should be with the other filters at the bottom. Burying the
grouping toggles in the gear menu likely means they won't get noticed or used.

The existing filter buttons / controls don't make sense anymore. We should
revamp that to make sense, especially in light of recent controls being added
(bug 200425) in poor places because of the existing filter controls.

I want new icons, or at least an icon for origins in the "Group by Path" view
(bug 200683).

In "Group by Path" I've had cases where deep nested folders gave a poor
experience. That may just be a follow-up bug.

Finally, we have a few features in the pipeline (Bootstrap, Blackboxing) that
are about to land. We should land those first and ensure they are at the
quality bar we want before enabling the tab by default.

More information about the webkit-reviews mailing list