[webkit-reviews] review granted: [Bug 200482] Web Inspector: RTL: Console should be always LTR : [Attachment 375981] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 16 01:09:51 PDT 2019

Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 200482: Web Inspector: RTL: Console should be always LTR

Attachment 375981: Patch


--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 375981
  --> https://bugs.webkit.org/attachment.cgi?id=375981

View in context: https://bugs.webkit.org/attachment.cgi?id=375981&action=review


> Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js:44
> +	   this._element.dir = "ltr";

Why do we put the `dir=ltr` on the ConsoleMessageView / ConsoleCommandView and
not just on the LogContentView itself? Are there things in the Console log that
we still want to be RTL?

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.css:73
> +body[dir=rtl] [dir=ltr] .tree-outline .item :matches(.disclosure-button,
.icon) {

Nice, I like this approach.

More information about the webkit-reviews mailing list