[webkit-reviews] review denied: [Bug 200747] Web Inspector: have more aggressive checks for dataURLs provided to `console.screenshot` : [Attachment 376338] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200747: Web Inspector: have more aggressive checks for dataURLs provided to
`console.screenshot`
https://bugs.webkit.org/show_bug.cgi?id=200747

Attachment 376338: Patch

https://bugs.webkit.org/attachment.cgi?id=376338&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 376338
  --> https://bugs.webkit.org/attachment.cgi?id=376338
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376338&action=review

> LayoutTests/inspector/console/console-screenshot.html:142
> +    addTest({
> +	   name: "console.screenshot.String.Base64.InvalidContent",
> +	   expression: `console.screenshot("data:image/png;base64,<INVALID>")`,
> +	   shouldCaptureViewport: true,
> +    });

r-, I wonder not expect if the user explicitly provides a dataURL for it to
capture the viewport.