[webkit-reviews] review granted: [Bug 200778] Yellow Lookup highlight gets stuck over Mail messages : [Attachment 376406] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 15 12:19:04 PDT 2019
Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 200778: Yellow Lookup highlight gets stuck over Mail messages
https://bugs.webkit.org/show_bug.cgi?id=200778
Attachment 376406: Patch
https://bugs.webkit.org/attachment.cgi?id=376406&action=review
--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 376406
--> https://bugs.webkit.org/attachment.cgi?id=376406
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=376406&action=review
> Source/WebKitLegacy/mac/WebView/WebView.mm:9511
> + [weakSelf.get()
_clearTextIndicatorWithAnimation:TextIndicatorWindowDismissalAnimation::FadeOut
];
Nit - I don’t think the .get() is necessary here.
More information about the webkit-reviews
mailing list