[webkit-reviews] review granted: [Bug 200104] Web Inspector: allow comments in protocol JSON : [Attachment 374844] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 6 10:25:41 PDT 2019
Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 200104: Web Inspector: allow comments in protocol JSON
https://bugs.webkit.org/show_bug.cgi?id=200104
Attachment 374844: Patch
https://bugs.webkit.org/attachment.cgi?id=374844&action=review
--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 374844
--> https://bugs.webkit.org/attachment.cgi?id=374844
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=374844&action=review
>
Source/JavaScriptCore/inspector/scripts/tests/all/expected/definitions-with-mac
-platform.json-result:471
> + Ref<JSON::Object> jsonResult = m_result.releaseNonNull();
Please rebaseline stale results in a separate commit. It doesn't need to be
reviewed.
More information about the webkit-reviews
mailing list