[webkit-reviews] review granted: [Bug 160993] Web Inspector: Show radius values in box model metrics view : [Attachment 375605] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 6 10:21:39 PDT 2019
Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 160993: Web Inspector: Show radius values in box model metrics view
https://bugs.webkit.org/show_bug.cgi?id=160993
Attachment 375605: Patch
https://bugs.webkit.org/attachment.cgi?id=375605&action=review
--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 375605
--> https://bugs.webkit.org/attachment.cgi?id=375605
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=375605&action=review
r=me, nice polish work.
> Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js:167
> + if (!value || (prefix !== "position" && value === "0px") ||
(prefix === "position" && value === "auto"))
I'm fine with the ternary above, but please break this into separate branches
for readability.
More information about the webkit-reviews
mailing list