[webkit-reviews] review denied: [Bug 195623] Link prefetch not useful for top-level navigation : [Attachment 368016] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 195623: Link prefetch not useful for top-level navigation
https://bugs.webkit.org/show_bug.cgi?id=195623

Attachment 368016: Patch

https://bugs.webkit.org/attachment.cgi?id=368016&action=review




--- Comment #158 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 368016
  --> https://bugs.webkit.org/attachment.cgi?id=368016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368016&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.h:560
> +    PrefetchCache m_prefetchCache;

This should probably live on the NetworkSession.  We don't want private
browsing to share state with non-private browsing.

> Source/WebKit/NetworkProcess/cache/PrefetchCache.h:50
> +	   RefPtr<WebCore::SharedBuffer> releaseBuffer() { return
buffer.releaseNonNull(); }

If we're really releasing non null, then this could be a Ref.

> LayoutTests/http/tests/contentextensions/prefetch-blocked.html.json:7
> +	       "url-filter": "should-not-load"

This trigger should have "resource-type": "document"