[webkit-reviews] review granted: [Bug 197188] [iOS] element.focus() sometimes fails to reveal the focused element when it becomes editable dynamically : [Attachment 368015] Fixes the bug

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 197188: [iOS] element.focus() sometimes fails to reveal the focused element
when it becomes editable dynamically
https://bugs.webkit.org/show_bug.cgi?id=197188

Attachment 368015: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=368015&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 368015
  --> https://bugs.webkit.org/attachment.cgi?id=368015
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=368015&action=review

> Source/WebCore/ChangeLog:8
> +	   The bug was caused by the scroll-to-reveal code trgiggered by
Element::updateFocusAppearance updating

Nit - "trgiggered" => triggered

> Source/WebCore/ChangeLog:10
> +	   _zoomToRevealFocusedElement in WKWebContent view had already
scrolled the frame view.

Nit - "WKWebContent view" => WKContentView