[webkit-reviews] review granted: [Bug 196922] [WTF] holdLock should be marked WARN_UNUSED_RETURN : [Attachment 367476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 16:53:05 PDT 2019

Keith Miller <keith_miller at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 196922: [WTF] holdLock should be marked WARN_UNUSED_RETURN

Attachment 367476: Patch


--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 367476
  --> https://bugs.webkit.org/attachment.cgi?id=367476

View in context: https://bugs.webkit.org/attachment.cgi?id=367476&action=review


> Source/JavaScriptCore/heap/BlockDirectory.cpp:66
> +	       // FIXME: should we instead do a cheaper thing like a volatile
load in the page?

Wow, that’s weird. What’s this function used for?

More information about the webkit-reviews mailing list