[webkit-reviews] review granted: [Bug 196947] ews-build should clearly indicate flaky test failures : [Attachment 367473] Patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 196947: ews-build should clearly indicate flaky test failures
https://bugs.webkit.org/show_bug.cgi?id=196947

Attachment 367473: Patch

https://bugs.webkit.org/attachment.cgi?id=367473&action=review




--- Comment #2 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 367473
  --> https://bugs.webkit.org/attachment.cgi?id=367473
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367473&action=review

r=me after checking the first/second variable name.

> Tools/BuildSlaveSupport/ews-build/steps.py:802
> +	   self._addToLog('stderr', '\nFailures in API Test second run:
{}'.format(first_run_failures))

I think this should be second_run_failures.