[webkit-reviews] review granted: [Bug 189860] Web Inspector: determine hasVisibleEffect for each RecordingAction as it's processed : [Attachment 350441] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 26 16:44:32 PDT 2018


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 189860: Web Inspector: determine hasVisibleEffect for each RecordingAction
as it's processed
https://bugs.webkit.org/show_bug.cgi?id=189860

Attachment 350441: Patch

https://bugs.webkit.org/attachment.cgi?id=350441&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 350441
  --> https://bugs.webkit.org/attachment.cgi?id=350441
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350441&action=review

r=me, nice!

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:430
> +	   function isArray(x) {

How about naming this `isArrayLike` or `isNativeArrayType`


More information about the webkit-reviews mailing list