[webkit-reviews] review granted: [Bug 189872] Video track clone cannot preserve original property : [Attachment 350920] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Wendy <yuhan_wu at apple.com>'s
request for review:
Bug 189872: Video track clone cannot preserve original property
https://bugs.webkit.org/show_bug.cgi?id=189872

Attachment 350920: Patch

https://bugs.webkit.org/attachment.cgi?id=350920&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 350920
  --> https://bugs.webkit.org/attachment.cgi?id=350920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350920&action=review

> Source/WebCore/ChangeLog:8
> +

Can you provide more information about changes?
For instance describe what was the issue.

> Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h:43
> +    static Ref<CanvasCaptureMediaStreamTrack>
create(ScriptExecutionContext&, Ref<HTMLCanvasElement>&&,
Ref<MediaStreamTrackPrivate>&& privateTrack);

It might be good to not define this create() method and directly call
adoptRef(*new ...) in CanvasCaptureMediaStreamTrack::clone().