[webkit-reviews] review granted: [Bug 189656] Add more Fullscreen logging : [Attachment 349874] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 189656: Add more Fullscreen logging
https://bugs.webkit.org/show_bug.cgi?id=189656

Attachment 349874: Patch

https://bugs.webkit.org/attachment.cgi?id=349874&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 349874
  --> https://bugs.webkit.org/attachment.cgi?id=349874
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349874&action=review

> Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm:53
> +    LOG(Fullscreen, "VideoFullscreenModelVideoElement %p ctor", this);

For the model logging, you may want to consider using the runtime logging
macros. (We can't currently do runtime logging for the Manager classes; they
require a single Document to configure the logging.)