[webkit-reviews] review granted: [Bug 189663] REGRESSION (PSON): White or Black flash occurs when process swapping on navigation on Mac : [Attachment 349886] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 189663: REGRESSION (PSON): White or Black flash occurs when process
swapping on navigation on Mac
https://bugs.webkit.org/show_bug.cgi?id=189663

Attachment 349886: patch

https://bugs.webkit.org/attachment.cgi?id=349886&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 349886
  --> https://bugs.webkit.org/attachment.cgi?id=349886
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349886&action=review

r=me

> Source/WebKit/ChangeLog:24
> +	   We no longer tear down drawing area (layer tree) for suspended pages
automatically. Send an explicit
> +	   message for it.

How do we ensure that suspended but not navigated pages tear down their layer
trees? I don't see a call to tearDownDrawingAreaInWebProcess in that case. Is
it already covered some other way?

> Source/WebKit/WebProcess/WebPage/WebPage.messages.in:509
> +    TearDownDrawingAreaForSuspended();

Let's call this TearDownDrawingAreaForSuspend.