[webkit-reviews] review granted: [Bug 189647] [GStreamer] Add support for AV1 decoding : [Attachment 349883] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 17 05:31:41 PDT 2018
Xabier RodrÃguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 189647: [GStreamer] Add support for AV1 decoding
https://bugs.webkit.org/show_bug.cgi?id=189647
Attachment 349883: Patch
https://bugs.webkit.org/attachment.cgi?id=349883&action=review
--- Comment #18 from Xabier RodrÃguez Calvar <calvaris at igalia.com> ---
Comment on attachment 349883
--> https://bugs.webkit.org/attachment.cgi?id=349883
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=349883&action=review
>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2364
> + return av1DecoderFound ? MediaPlayer::IsSupported :
MediaPlayer::IsNotSupported;
> + if (codec.startsWith("av1"_s))
> + return MediaPlayer::IsNotSupported;
> + }
> + return extendedSupportsType(parameters, result);
Well, this is not what I meant, sorry for not being clear the first time. What
I meant is that you should use "result", let execution continue till the end of
the function and then call extendedSupportsType there. So remove these replace
these three returns with result = when needed.
More information about the webkit-reviews
mailing list