[webkit-reviews] review granted: [Bug 189635] Enable VCP for iOS and reenable it for MacOS : [Attachment 349865] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 189635: Enable VCP for iOS and reenable it for MacOS
https://bugs.webkit.org/show_bug.cgi?id=189635

Attachment 349865: Patch

https://bugs.webkit.org/attachment.cgi?id=349865&action=review




--- Comment #13 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 349865
  --> https://bugs.webkit.org/attachment.cgi?id=349865
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349865&action=review

> Source/WebCore/ChangeLog:11
> +	   Add internal API to knwo whether VCP is enabled so as to make
capture-webrtc test pass on all platforms.

Nit: “know”

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
36
> +#if (defined(TARGET_OS_IPHONE)  && TARGET_OS_IPHONE)

Nit: not new, but there are two spaces before the “&&”