[webkit-reviews] review granted: [Bug 191093] [Win][Direct2D] Support building DumpRenderTree for Direct2D : [Attachment 353442] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 191093: [Win][Direct2D] Support building DumpRenderTree for Direct2D
https://bugs.webkit.org/show_bug.cgi?id=191093

Attachment 353442: Patch

https://bugs.webkit.org/attachment.cgi?id=353442&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 353442
  --> https://bugs.webkit.org/attachment.cgi?id=353442
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353442&action=review

r=me

> Tools/DumpRenderTree/win/PixelDumpSupportDirect2D.cpp:41
> +using namespace std;

Please no.

> Tools/DumpRenderTree/win/PixelDumpSupportDirect2D.h:31
> +#include <vector>

let's not.

> Tools/DumpRenderTree/win/PixelDumpSupportDirect2D.h:52
> +    std::vector<unsigned char> m_data;

Vector<uint8_t>
Also, this isn't used.