[webkit-reviews] review granted: [Bug 191046] [PSON] When process-swapping for a POST request the HTTP body gets dropped : [Attachment 353329] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 191046: [PSON] When process-swapping for a POST request the HTTP body gets
dropped
https://bugs.webkit.org/show_bug.cgi?id=191046

Attachment 353329: Patch

https://bugs.webkit.org/attachment.cgi?id=353329&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 353329
  --> https://bugs.webkit.org/attachment.cgi?id=353329
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353329&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:4189
> +    // Make the request whole again before passing it to
decidePolicyForNavigationAction().
> +    request.setHTTPBody(requestBody.takeData());

Would it not be better to move this logic to decidePolicyForNavigationAction so
we don't have duplicate code?  There could be one comment there explaining why.

> LayoutTests/http/tests/misc/form-post-textplain-cross-site.html:3
> +<title>Regression test for bug 20795 and 100445</title>

And 191046?