[webkit-reviews] review granted: [Bug 189289] [WebAuthN] Import CTAP HID message and packet structure from Chromium : [Attachment 351870] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 09:23:08 PDT 2018


Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 189289: [WebAuthN] Import CTAP HID message and packet structure from
Chromium
https://bugs.webkit.org/show_bug.cgi?id=189289

Attachment 351870: Patch

https://bugs.webkit.org/attachment.cgi?id=351870&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 351870
  --> https://bugs.webkit.org/attachment.cgi?id=351870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351870&action=review

> Source/WebCore/Modules/webauthn/fido/FidoHidMessage.cpp:89
> +    if (initPacket == nullptr)

if (!initPacket)

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:-194
> -

Please remove this whitespace change.


More information about the webkit-reviews mailing list