[webkit-reviews] review granted: [Bug 190392] StringTypeAdapter constructor is not properly enforcing String::MaxLength. : [Attachment 351859] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 9 09:08:52 PDT 2018
Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 190392: StringTypeAdapter constructor is not properly enforcing
String::MaxLength.
https://bugs.webkit.org/show_bug.cgi?id=190392
Attachment 351859: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=351859&action=review
--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 351859
--> https://bugs.webkit.org/attachment.cgi?id=351859
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=351859&action=review
> Source/WTF/ChangeLog:11
> + length a size_t which removes this issue, and assert that it's
within
We’re ok with this not working on 32bit? Maybe just use uint64_t directly?
More information about the webkit-reviews
mailing list