[webkit-reviews] review denied: [Bug 190225] Web Inspector: merge ProbeManager into DebuggerManager : [Attachment 351453] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 190225: Web Inspector: merge ProbeManager into DebuggerManager
https://bugs.webkit.org/show_bug.cgi?id=190225

Attachment 351453: Patch

https://bugs.webkit.org/attachment.cgi?id=351453&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 351453
  --> https://bugs.webkit.org/attachment.cgi?id=351453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351453&action=review

r-

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:1276
> +	       this._breakpointAdded(breakpoint);

This appears to call _breakpointAdded which doesn't exist anymore... Given the
subtlety in renaming and moving things this might need more work. It is unclear
all of the changes that happened in this merge.