[webkit-reviews] review granted: [Bug 190224] Web Inspector: merge SourceMapManager into NetworkManager : [Attachment 351451] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 190224: Web Inspector: merge SourceMapManager into NetworkManager
https://bugs.webkit.org/show_bug.cgi?id=190224

Attachment 351451: Patch

https://bugs.webkit.org/attachment.cgi?id=351451&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 351451
  --> https://bugs.webkit.org/attachment.cgi?id=351451
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351451&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:41
> +	   this._sourceMapURLMap = {};
> +	   this._downloadingSourceMaps = {};

We could modernize this to be a Map and Set. That can be another time.

> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:389
> -	      
WI.sourceMapManager.downloadSourceMap(cachedResourcePayload.sourceMapURL,
resource.url, resource);
> +	      
WI.networkManager.downloadSourceMap(cachedResourcePayload.sourceMapURL,
resource.url, resource);

Shouldn't these just be `this.` instead of `WI.networkManager.`?