[webkit-reviews] review canceled: [Bug 192128] Make generic ScrollAnimator : [Attachment 355956] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 29 05:50:20 PST 2018


Frédéric Wang (:fredw) <fred.wang at free.fr> has canceled  review:
Bug 192128: Make generic ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=192128

Attachment 355956: Patch

https://bugs.webkit.org/attachment.cgi?id=355956&action=review




--- Comment #4 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 355956
  --> https://bugs.webkit.org/attachment.cgi?id=355956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review

>> Source/WebCore/ChangeLog:15
>> +	    compile at this time.
> 
> ScrollAnimatorSmooth seems to be still used on GTK:
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59
> 
> Also, I've been relying on this to implement CSS smooth scrolling on all
ports bug 188043. So unless reviewers say my approach is incorrect, please keep
the file for now :-)

OK, I stand corrected, what I need is ScrollAnimationSmooth!


More information about the webkit-reviews mailing list