[webkit-reviews] review denied: [Bug 192128] Make generic ScrollAnimator : [Attachment 355956] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 29 05:38:49 PST 2018
Frédéric Wang (:fredw) <fred.wang at free.fr> has denied Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 192128: Make generic ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=192128
Attachment 355956: Patch
https://bugs.webkit.org/attachment.cgi?id=355956&action=review
--- Comment #3 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 355956
--> https://bugs.webkit.org/attachment.cgi?id=355956
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review
> Source/WebCore/ChangeLog:15
> + compile at this time.
ScrollAnimatorSmooth seems to be still used on GTK:
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59
Also, I've been relying on this to implement CSS smooth scrolling on all ports
bug 188043. So unless reviewers say my approach is incorrect, please keep the
file for now :-)
More information about the webkit-reviews
mailing list