[webkit-reviews] review granted: [Bug 191810] Clarify RenderLayerCompositor::hasAnyAdditionalCompositedLayers() and related code. : [Attachment 355202] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 17 14:08:08 PST 2018


zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 191810: Clarify RenderLayerCompositor::hasAnyAdditionalCompositedLayers()
and related code.
https://bugs.webkit.org/show_bug.cgi?id=191810

Attachment 355202: Patch

https://bugs.webkit.org/attachment.cgi?id=355202&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 355202
  --> https://bugs.webkit.org/attachment.cgi?id=355202
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355202&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1257
> +    if (&layer != m_renderView.layer()) {
> +	   ASSERT(m_contentLayersCount > 0);
> +	   --m_contentLayersCount;
> +    }

Don't we prefer the early return style?
if (&layer == m_renderView.layer())
    return;


More information about the webkit-reviews mailing list