[webkit-reviews] review granted: [Bug 191734] ASSERTION FAILED: m_messageReceivers.contains(...) under ViewGestureController removeMessageReceiver : [Attachment 355201] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 17 14:08:10 PST 2018


Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 191734: ASSERTION FAILED: m_messageReceivers.contains(...) under
ViewGestureController removeMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=191734

Attachment 355201: Patch

https://bugs.webkit.org/attachment.cgi?id=355201&action=review




--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 355201
  --> https://bugs.webkit.org/attachment.cgi?id=355201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355201&action=review

Looks sane to me. I guess we should wait for EWS.

> Source/WebKit/ChangeLog:10
> +	   after we've relaunched a new Webprocess. The ViewGestureController
controller takes care

Nit: Web*P*rocess.

> Source/WebKit/ChangeLog:19
> +	   To address the issue, we now take sure the ViewGestureController
unregisters itself from

we now *make* sure?


More information about the webkit-reviews mailing list