[webkit-reviews] review granted: [Bug 191602] WebKit.ApplicationManifestBasic API test is failing when enabling PSON : [Attachment 354749] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 191602: WebKit.ApplicationManifestBasic API test is failing when enabling
PSON
https://bugs.webkit.org/show_bug.cgi?id=191602

Attachment 354749: Patch

https://bugs.webkit.org/attachment.cgi?id=354749&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 354749
  --> https://bugs.webkit.org/attachment.cgi?id=354749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354749&action=review

> Source/WebKit/UIProcess/API/APINavigation.h:159
> +    std::optional<SubstituteData> m_substituteData;

Since it is uncommon it might be a little better to use std::unique_ptr so we
don't have to always use the memory of the whole structure.

> Source/WebKit/UIProcess/WebNavigationState.h:54
> +    Ref<API::Navigation> createLoadDataNavigation(const IPC::DataReference&,
const String& MIMEType, const String& encoding, const String& baseURL,
API::Object* userData);

We already have a struct.  Couldn't we just add one parameter here?