[webkit-reviews] review granted: [Bug 191590] Convert libwebrtc error types to DOM exceptions : [Attachment 354683] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 191590: Convert libwebrtc error types to DOM exceptions
https://bugs.webkit.org/show_bug.cgi?id=191590

Attachment 354683: Patch

https://bugs.webkit.org/attachment.cgi?id=354683&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 354683
  --> https://bugs.webkit.org/attachment.cgi?id=354683
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354683&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:132
> -OTHER_LDFLAGS_PLATFORM_macosx = -sub_library libobjc -umbrella WebKit;
> +OTHER_LDFLAGS_PLATFORM_macosx = -sub_library libobjc -umbrella WebKit
-Xlinker --no-demangle;

I'm not sure this is a good change.