[webkit-reviews] review granted: [Bug 191553] Web Inspector: Canvas: don't start with auto-capture enabled : [Attachment 354569] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 191553: Web Inspector: Canvas: don't start with auto-capture enabled
https://bugs.webkit.org/show_bug.cgi?id=191553

Attachment 354569: Patch

https://bugs.webkit.org/attachment.cgi?id=354569&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 354569
  --> https://bugs.webkit.org/attachment.cgi?id=354569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354569&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js:226
>	      
this._recordingAutoCaptureFrameCountInputElement.style.setProperty("width",
(textMetrics.width + 8) + "px");

Out of curiosity, where does the 8px come from? It looks like it comes from
canvasOverviewContentView.css:184:

.navigation-bar > .item.canvas-recording-auto-capture > label > input {
    width: 1.5em;
    min-width: 1.5em;
    margin: 0 4px;
    text-align: center;
}

If so this should be a const, with a comment warning to keep it in sync with
the stylesheet. I know this is off topic for this patch, but I noticed it while
reading the file for context.