[webkit-reviews] review denied: [Bug 190836] [BigInt] JSBigInt::createWithLength should throw when length is greater than JSBigInt::maxLength : [Attachment 354573] Patch

[bugzilla-daemon at webkit.org]

Caio Lima <ticaiolima at gmail.com> has denied Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 190836: [BigInt] JSBigInt::createWithLength should throw when length is
greater than JSBigInt::maxLength
https://bugs.webkit.org/show_bug.cgi?id=190836

Attachment 354573: Patch

https://bugs.webkit.org/attachment.cgi?id=354573&action=review




--- Comment #10 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 354573
  --> https://bugs.webkit.org/attachment.cgi?id=354573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354573&action=review

>> Source/JavaScriptCore/runtime/JSBigInt.cpp:414
>> +	    JSBigInt* y1 = absoluteSubOne(exec, y, y->length());
> 
> Don't you also need an exception check after this?

Yes. Actually I realised this is the wrong version of the Patch.