[webkit-reviews] review granted: [Bug 191096] Force a gregorian calendar to show for credit card expiration date inputs (autocomplete='cc-exp'*) : [Attachment 353835] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Zamiul Haque <zhaque at apple.com>'s
request for review:
Bug 191096: Force a gregorian calendar to show for credit card expiration date
inputs (autocomplete='cc-exp'*)
https://bugs.webkit.org/show_bug.cgi?id=191096

Attachment 353835: Patch

https://bugs.webkit.org/attachment.cgi?id=353835&action=review




--- Comment #22 from Tim Horton <thorton at apple.com> ---
Comment on attachment 353835
  --> https://bugs.webkit.org/attachment.cgi?id=353835
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353835&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5954
> +- (WKFormInputControl *)formInputPeripheral

Doesn't this still have the wrong name? (shouldn't it be formInputControl?)

> Tools/WebKitTestRunner/TestController.h:32
> +#if PLATFORM(COCOA)

#conditionals inside the include list go down in their own paragraph.

>
LayoutTests/fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html
:42
> +	       // Print human readable description of test if test runner is
not running

Don't really need this comment