[webkit-reviews] review denied: [Bug 189718] Web Inspector: Table should support shift-extending the row selection : [Attachment 353753] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has denied Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 189718: Web Inspector: Table should support shift-extending the row
selection
https://bugs.webkit.org/show_bug.cgi?id=189718

Attachment 353753: Patch

https://bugs.webkit.org/attachment.cgi?id=353753&action=review




--- Comment #15 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 353753
  --> https://bugs.webkit.org/attachment.cgi?id=353753
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353753&action=review

> Source/WebInspectorUI/UserInterface/Views/Table.js:1345
> +    _handleKeyUp(event)
> +    {
> +	   if (event.keyIdentifier === "Shift")
> +	       this._shiftExtendAnchorIndex = NaN;
> +    }

Try this:

Press Shift
Click row #2
Click row #3
Release Shift
Press Shift
Click row #1

With this patch: rows 1-3 are selected.

In Finder: rows 1-2 are selected. This is because Finder doesn't clear
anchorIndex when the Shift key is released.