[webkit-reviews] review requested: [Bug 191167] [CMake] Sync feature defines : [Attachment 353900] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 5 13:04:57 PST 2018
Don Olmstead <don.olmstead at sony.com> has asked for review:
Bug 191167: [CMake] Sync feature defines
https://bugs.webkit.org/show_bug.cgi?id=191167
Attachment 353900: Patch
https://bugs.webkit.org/attachment.cgi?id=353900&action=review
--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 353900
--> https://bugs.webkit.org/attachment.cgi?id=353900
Patch
I searched in the XCode configs for ENABLE_* flags and if they weren't present
I added them here.
I found a few ENABLE_* that were no longer in use like ENABLE_IOS_AIRPLAY,
ENABLE_WEB_CRYPTO and ENABLE_WEBVTT_REGIONS.
I have some scripts around this hanging out locally. Perhaps in the future we
can generate those two files rather than doing hand editing.
More information about the webkit-reviews
mailing list