[webkit-reviews] review granted: [Bug 178316] Implement Cache API support for WPE/GTK : [Attachment 353717] fixed cache quota test for gkt/wpe

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted darshan
<dkadu at igalia.com>'s request for review:
Bug 178316: Implement Cache API support for WPE/GTK
https://bugs.webkit.org/show_bug.cgi?id=178316

Attachment 353717: fixed cache quota test for gkt/wpe

https://bugs.webkit.org/attachment.cgi?id=353717&action=review




--- Comment #19 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 353717
  --> https://bugs.webkit.org/attachment.cgi?id=353717
fixed cache quota test for gkt/wpe

View in context: https://bugs.webkit.org/attachment.cgi?id=353717&action=review

OK, this patch looks good to me. Great that the tests are passing on WPE/GTK
now! I'm marked r+ but I see you already started to do the refactoring
suggested by Michael, so let's just finish that refactoring in this bug then.
It is probably not be hard enough to justify a follow-up bug.

> LayoutTests/ChangeLog:10
> +

As I said for the other patch, you should give details of the changes in the
ChangeLog.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h:-116
> -

As I said for the other patch, you probably don't want to remove that new line.