[webkit-reviews] review denied: [Bug 178316] Implement Cache API support for WPE/GTK : [Attachment 353720] fixed cache quota test with all the platform having same storage

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has denied  review:
Bug 178316: Implement Cache API support for WPE/GTK
https://bugs.webkit.org/show_bug.cgi?id=178316

Attachment 353720: fixed cache quota test with all the platform having same
storage

https://bugs.webkit.org/attachment.cgi?id=353720&action=review




--- Comment #18 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 353720
  --> https://bugs.webkit.org/attachment.cgi?id=353720
fixed cache quota test with all the platform having same storage

View in context: https://bugs.webkit.org/attachment.cgi?id=353720&action=review

> LayoutTests/ChangeLog:10
> +

The three ChangeLogs should be updated and completed with explanations in the
final patch.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h:116
> +WK_EXPORT void
WKWebsiteDataStoreSetCacheStoragePerOriginQuota(WKWebsiteDataStoreRef
dataStoreRef, uint64_t quota);

It seems this new line was on purpose (to separate
ServiceWorkerRegistrationDirectory) so you should not remove it

> Tools/WebKitTestRunner/TestController.cpp:479
> +    initializeCacheStoragePerOriginQuota();

I think you can just call WKWebsiteDataStoreSetCacheStoragePerOriginQuota here
and remove Cocoa-specific stuff.

> Tools/WebKitTestRunner/TestController.cpp:527
> +{

I don't think you need this function if it's only called in
TestController::generatePageConfiguration()